Manno15 edited a comment on pull request #1784:
URL: https://github.com/apache/accumulo/pull/1784#issuecomment-728971938


   @ctubbsii I did not see that warning but I will take a look.
   
   Thank you for taking another look at it for me. I did some checks on the 
shell myself and I noticed no issue.
   
   The `\t` changes were necessary because for some reason it would error out 
without them for the upgraded version but not for 2.11. It wouldn't accept that 
they were equal now. I noticed when I copy-pasted the result from the shell 
into the string it automatically added the `\t` for me and it worked. That is 
what caused most of the errors from these changes. 
   
   I suppose it is also possible to just strip out the `\t` when we print to 
the shell. Maybe that would be a better change, we wouldn't have to make add 
the `\t` in all the related IT's.
   
   I think the other things mentioned are just what else was fixed in 2.14.2. I 
noticed it was just copied from the release notes from Jline. Not sure if it 
was intended as something to add additional to the upgrade for accumulo.  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to