ctubbsii commented on a change in pull request #1832:
URL: https://github.com/apache/accumulo/pull/1832#discussion_r539510581



##########
File path: test/src/main/java/org/apache/accumulo/test/AuditMessageIT.java
##########
@@ -482,6 +482,10 @@ public void testDeniedAudits() throws 
AccumuloSecurityException, AccumuloExcepti
       auditConnector.tableOperations().deleteRows(OLD_TEST_TABLE_NAME, new 
Text("myRow"),
           new Text("myRow~"));
     } catch (AccumuloSecurityException ex) {}
+    try {
+      auditConnector.tableOperations().flush(OLD_TEST_TABLE_NAME, new 
Text("start"),
+              new Text("end"), false);

Review comment:
       Normally, a range would be specified so that the start sorts before the 
end, but 's' sorts after 'e'. You should change it to match `myRow` and 
`myRow~` like the previous line, instead, so that way this will still work, 
even if we later add additional argument checks to make sure the start sorts 
before the end.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to