ctubbsii commented on pull request #1832:
URL: https://github.com/apache/accumulo/pull/1832#issuecomment-742524904


   > @ctubbsii As it stands currently, you only need write permissions to flush 
a table. Do you think I should add separate permissions for Flush specifically 
(not fully sure how to do this and make it functional. I did add the permission 
option though), piggyback off the write permission check to also do a flush of 
the table, or leave as is and assume that permission is checked correctly since 
they share permissions?
   > 
   
   There's no need to change any permissions. The test can simply add a user 
that lacks the appropriate permission, and can verify that the appropriate 
AccumuloSecurityException denial is thrown if a flush is attempted.
   
   > I also noticed that in `PermissionsIT` that the test case for system 
permissions isn't actually there and is left as a to-do I assume. Not sure if 
there was a good reason why that was left undone.
   
   It probably just wasn't in scope of the original issue. Maybe there's 
another test that checks those? It can be added to this one, if not.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to