dlmarion commented on a change in pull request #1840:
URL: https://github.com/apache/accumulo/pull/1840#discussion_r545361484
##########
File path:
server/tserver/src/main/java/org/apache/accumulo/tserver/scan/LookupTask.java
##########
@@ -177,9 +177,13 @@ public void run() {
}
} catch (SampleNotPresentException e) {
addResult(e);
- } catch (Throwable e) {
+ } catch (Exception e) {
log.warn("exception while doing multi-scan ", e);
addResult(e);
+ } catch (Error t) {
+ log.warn("Error while doing multi-scan ", t);
+ addResult(t);
Review comment:
I was following what the other catch clauses were doing here. I assume
that the addResult() call is putting the exception on the result queue to be
sent back to the client. It's possible that this error could make it's way back
to the client before the tserver is halted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
