ctubbsii commented on a change in pull request #1840:
URL: https://github.com/apache/accumulo/pull/1840#discussion_r545388080
##########
File path:
server/tserver/src/main/java/org/apache/accumulo/tserver/scan/LookupTask.java
##########
@@ -177,9 +177,13 @@ public void run() {
}
} catch (SampleNotPresentException e) {
addResult(e);
- } catch (Throwable e) {
+ } catch (Exception e) {
log.warn("exception while doing multi-scan ", e);
addResult(e);
+ } catch (Error t) {
+ log.warn("Error while doing multi-scan ", t);
+ addResult(t);
Review comment:
If there's an actual Error, we probably shouldn't leak those details to
the client. The client will get a TApplicationException when the server fails.
It's probably not worth creating new work before the Error falls through and is
ultimately handled. We probably also don't need the log message, either,
because the code that will eventually handle the Error should provide a useful
message/stack trace, and this would be redundant. It's probably better to just
let it fall through and not even try to catch-handle-rethrow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
