ctubbsii commented on a change in pull request #1818:
URL: https://github.com/apache/accumulo/pull/1818#discussion_r556541601
##########
File path: core/src/main/java/org/apache/accumulo/core/util/Halt.java
##########
@@ -50,10 +51,9 @@ public void run() {
public static void halt(final int status, Runnable runnable) {
try {
// give ourselves a little time to try and do something
- new Thread() {
+ new Daemon() {
Review comment:
We should avoid using Hadoop's Daemon. I doubt that is stable public
API. Even if it is, we don't want to increase our dependency on Hadoop library
code for this. It should be simple to construct the object assigned to a local
variable, set it to daemon, and start it in 3 statements, rather than rely on a
the Hadoop library.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
