dlmarion commented on a change in pull request #1818:
URL: https://github.com/apache/accumulo/pull/1818#discussion_r556552871
##########
File path:
core/src/main/java/org/apache/accumulo/core/classloader/DefaultContextClassLoaderFactory.java
##########
@@ -59,18 +60,20 @@ public DefaultContextClassLoaderFactory(final
AccumuloConfiguration accConf) {
}
private static void startCleanupThread(final Supplier<Map<String,String>>
contextConfigSupplier) {
- new Timer(className + "-cleanup", true).scheduleAtFixedRate(new
TimerTask() {
- @Override
- public void run() {
- Map<String,String> contextConfigs = contextConfigSupplier.get();
- LOG.trace("{}-cleanup thread, properties: {}", className,
contextConfigs);
- int prefixlen =
Property.VFS_CONTEXT_CLASSPATH_PROPERTY.getKey().length();
- Set<String> contextsInUse = contextConfigs.keySet().stream()
- .map(k -> k.substring(prefixlen)).collect(Collectors.toSet());
- LOG.trace("{}-cleanup thread, contexts in use: {}", className,
contextsInUse);
- AccumuloVFSClassLoader.removeUnusedContexts(contextsInUse);
- }
- }, 60_000, 60_000);
+ final ConfigurationCopy cc = new
ConfigurationCopy(contextConfigSupplier.get());
+ String size = cc.get(Property.GENERAL_SIMPLETIMER_THREADPOOL_SIZE);
+ if (null == size || size.isEmpty()) {
+ cc.set(Property.GENERAL_SIMPLETIMER_THREADPOOL_SIZE,
+ Property.GENERAL_SIMPLETIMER_THREADPOOL_SIZE.getDefaultValue());
+ }
+ ThreadPools.createGeneralScheduledExecutorService(cc)
+ .scheduleWithFixedDelay(Threads.createNamedRunnable(className +
"-cleanup", () -> {
+ LOG.trace("{}-cleanup thread, properties: {}", className, cc);
+ Set<String> contextsInUse = cc
+
.getAllPropertiesWithPrefixStripped(Property.VFS_CONTEXT_CLASSPATH_PROPERTY).keySet();
Review comment:
I read the code wrong, I think I need more coffee.
##########
File path: core/src/main/java/org/apache/accumulo/core/util/Halt.java
##########
@@ -50,10 +51,9 @@ public void run() {
public static void halt(final int status, Runnable runnable) {
try {
// give ourselves a little time to try and do something
- new Thread() {
+ new Daemon() {
Review comment:
I didn't even notice that it was a Hadoop class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
