keith-turner commented on a change in pull request #1891:
URL: https://github.com/apache/accumulo/pull/1891#discussion_r567490281
##########
File path:
server/base/src/main/java/org/apache/accumulo/server/master/balancer/TabletBalancer.java
##########
@@ -56,7 +56,11 @@
* Implementations may wish to store configuration in Accumulo's system
configuration using the
* {@link Property#GENERAL_ARBITRARY_PROP_PREFIX}. They may also benefit from
using per-table
* configuration using {@link Property#TABLE_ARBITRARY_PROP_PREFIX}.
+ *
+ * @deprecated since 2.1.0. Use {@link
org.apache.accumulo.core.spi.balancer.TabletBalancer}
+ * instead.
*/
+@Deprecated(since = "2.1.0")
public abstract class TabletBalancer {
Review comment:
@brianloss I just took a quick look at, I like how you pulled code out
of Master,TabletBalancer and moved it into AssignmentParamsImpl and
BalancerParamsImpl. Making those classes own the responsibility for converting
from the SPI types to the internal thrift types is nice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
