brianloss commented on a change in pull request #1891: URL: https://github.com/apache/accumulo/pull/1891#discussion_r568120107
########## File path: core/src/main/java/org/apache/accumulo/core/spi/balancer/DefaultLoadBalancer.java ########## @@ -0,0 +1,372 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.accumulo.core.spi.balancer; + +import java.util.ArrayList; +import java.util.Collections; +import java.util.HashMap; +import java.util.Iterator; +import java.util.List; +import java.util.Map; +import java.util.Map.Entry; +import java.util.Objects; +import java.util.Set; +import java.util.SortedMap; +import java.util.concurrent.TimeUnit; + +import org.apache.accumulo.core.client.AccumuloException; +import org.apache.accumulo.core.client.AccumuloSecurityException; +import org.apache.accumulo.core.data.TableId; +import org.apache.accumulo.core.data.TabletId; +import org.apache.accumulo.core.manager.balancer.TabletServerIdImpl; +import org.apache.accumulo.core.spi.balancer.data.TServerStatus; +import org.apache.accumulo.core.spi.balancer.data.TableStatistics; +import org.apache.accumulo.core.spi.balancer.data.TabletMigration; +import org.apache.accumulo.core.spi.balancer.data.TabletServerId; +import org.apache.accumulo.core.spi.balancer.data.TabletStatistics; +import org.apache.accumulo.core.spi.balancer.util.ThrottledBalancerProblemReporter; +import org.apache.accumulo.core.spi.balancer.util.ThrottledBalancerProblemReporter.OutstandingMigrationsProblem; +import org.apache.accumulo.core.spi.balancer.util.ThrottledBalancerProblemReporter.Problem; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * @since 2.1.0 + */ +public class DefaultLoadBalancer implements TabletBalancer { Review comment: @ctubbsii I agree that these changes make sense. I wasn't really trying to improve the interface in order to limit the scope of the work and the review for people. I can certainly make these changes now if you prefer, though. Or, I can add a ticket and submit changes like this (and others, such as: Keith and I also talked about moving the output parameters in the getAssignments and balance calls to return objects instead) in a follow-in PR. The only gotcha there is we need to be sure it's done before 2.1 or else we'll end up having to deprecate code we just added, which is clearly not a good idea. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
