keith-turner commented on a change in pull request #1899:
URL: https://github.com/apache/accumulo/pull/1899#discussion_r568994093
##########
File path:
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java
##########
@@ -556,14 +557,15 @@ private void manageMemory() {
continue;
}
Tablet tablet = tabletReport.getTablet();
- if
(!tablet.initiateMinorCompaction(MinorCompactionReason.SYSTEM)) {
- if (tablet.isClosed()) {
+ var state =
context.getTableManager().getTableState(tablet.getExtent().tableId());
+ if
(!tablet.initiateMinorCompaction(MinorCompactionReason.SYSTEM, state)) {
+ if (tablet.isClosed() || state.equals(TableState.DELETING)) {
Review comment:
If a tablet is in the deleteting state for a long time and holding lots
of memory, it seems like it could starve other minor compactions from ever
running. Does this deleting of reports help mitigate that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
