ctubbsii commented on a change in pull request #1899:
URL: https://github.com/apache/accumulo/pull/1899#discussion_r575213059
##########
File path:
server/tserver/src/test/java/org/apache/accumulo/tserver/memory/LargestFirstMemoryManagerTest.java
##########
@@ -204,22 +212,35 @@ protected long getMinCIdleThreshold(KeyExtent extent) {
protected boolean tableExists(TableId tableId) {
return true;
}
+
+ @Override
+ protected boolean tableBeingDeleted(TableId tableId) {
+ return false;
+ }
}
private static class LargestFirstMemoryManagerWithExistenceCheck
extends LargestFirstMemoryManagerUnderTest {
Function<TableId,Boolean> existenceCheck;
+ Function<TableId,Boolean> deletingCheck;
- public
LargestFirstMemoryManagerWithExistenceCheck(Function<TableId,Boolean>
existenceCheck) {
+ public
LargestFirstMemoryManagerWithExistenceCheck(Function<TableId,Boolean>
existenceCheck,
+ Function<TableId,Boolean> deletingCheck) {
super();
this.existenceCheck = existenceCheck;
+ this.deletingCheck = deletingCheck;
Review comment:
It'd be better to use the primitive functional interface that maps to a
boolean: `Predicate<TableId>` instead of `Function<TableId,Boolean>`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
