brianloss commented on a change in pull request #1904:
URL: https://github.com/apache/accumulo/pull/1904#discussion_r569769369
##########
File path: assemble/bin/accumulo-service
##########
@@ -69,7 +69,7 @@ function start_service() {
echo "Starting $service on $host"
if [[ $service == "manager" ]]; then
- "${bin}/accumulo" org.apache.accumulo.master.state.SetGoalState NORMAL
Review comment:
> I'm okay with this change, but there are two considerations that
should be made:
>
> 1. Any renamed file with a `main` method needs to be checked to see if we
need to create a compatibility class, in case it was called directly, and
@ctubbsii I pushed changes for this, and a missed default property value
update in Property
> 2. Since all the FaTE RepOs were renamed, we need to be sure that on
upgrade, we only proceed if there were no outstanding FaTE operations in ZK
whatsoever. Otherwise, we won't be able to deserialize and replay them.
I believe this is already happening in
[UgradeCoordinator](https://github.com/apache/accumulo/blob/main/server/manager/src/main/java/org/apache/accumulo/master/upgrade/UpgradeCoordinator.java#L144).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
