brianloss commented on a change in pull request #1904:
URL: https://github.com/apache/accumulo/pull/1904#discussion_r569771413
##########
File path: assemble/bin/accumulo-service
##########
@@ -69,7 +69,7 @@ function start_service() {
echo "Starting $service on $host"
if [[ $service == "manager" ]]; then
- "${bin}/accumulo" org.apache.accumulo.master.state.SetGoalState NORMAL
Review comment:
> The `KeywordExecutableIT` has a list of classes that were entry points
for users that were expected to have a `main` method. `Master` was one of them.
However, because we use `KeywordExecutable` to execute these classes, the
`main` methods are really optional... we don't need them. We only checked for
them for backwards compatibility. That check will fail to catch the break in
backwards compatibility if the IDE automatically renamed the imports for the
classes it was checking. The new classes do not need to keep the `main`
methods, since they were only there for backwards compatibility (in case
somebody wasn't using Accumulo's `Main` class with a keyword), so they don't
need to be kept in the new names.
I'll have a separate PR for renaming classes with Master in the name. If
it's ok, I'll take care of removing the main method from the Manager class at
that time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
