brianloss commented on pull request #1891: URL: https://github.com/apache/accumulo/pull/1891#issuecomment-772874729
> My only request for a change in this PR before it is merged is to rename the newly introduced SPI "DefaultLoadBalancer" to something like "BasicLoadBalancer" or "SimpleLoadBalancer" (unless there's a better, more descriptive name based on how it actually works), and with a brief class-level javadoc to describe the basic strategy. > > While the rename and addition of a javadoc could occur in a subsequent task, I think it makes more sense to have the better name (and basic description) in its initial introduction, since it is a wholly new class. @ctubbsii this is done in the latest commit. Let me know if you see anything else that needs addressed. Thanks! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
