ctubbsii commented on a change in pull request #1972:
URL: https://github.com/apache/accumulo/pull/1972#discussion_r595521559
##########
File path: core/src/main/java/org/apache/accumulo/fate/zookeeper/ZooLock.java
##########
@@ -106,11 +119,11 @@ public ZooLock(AccumuloConfiguration conf, String path,
UUID uuid) {
}
}
- protected ZooLock(ZooKeeper zookeeper, String path, UUID uuid) {
+ protected ZooLock(ZooKeeper zookeeper, ZooLockPath path, UUID uuid) {
Review comment:
@EdColeman In general, I agree with you, on the need for explicit
methods for serialization, rather than relying on `toString()`, but in this
case, I don't think it makes sense, since these are merely more strongly typed
strings, so `toString()` should always be implemented correctly. It's more
intuitive to think of these as more strongly typed strings, than it is to
consider them path object types that have getters to a contained path object
type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
