ctubbsii commented on pull request #1972: URL: https://github.com/apache/accumulo/pull/1972#issuecomment-801334257
> I like your additions. Some comments below, in order of the commit points. > > * The renaming was going to happen in #1967 which is why I didn't do it here. This PR can fix both #1966 and #1967. One PR to address two issues. I think `ServiceLock` is a good name for `ZooLock`, so if there aren't any objections to that name, I'll add that rename to this PR also, and then we can merge it and close both issues. > * Good change, I thought the fields were already final so that was my mistake. To be clear, my additions weren't corrective in any way. I didn't see any mistakes. My additions were supplemental only, building on what you did. :smiley_cat: ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
