milleruntime commented on a change in pull request #1968:
URL: https://github.com/apache/accumulo/pull/1968#discussion_r597832816
##########
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##########
@@ -166,21 +166,6 @@
PropertyType.STRING,
"One-line configuration property controlling the network locations "
+ "(hostnames) that are allowed to impersonate other users"),
- // Crypto-related properties
- @Experimental
- INSTANCE_CRYPTO_PREFIX("instance.crypto.opts.", null, PropertyType.PREFIX,
- "Properties related to on-disk file encryption."),
- @Experimental
- @Sensitive
- INSTANCE_CRYPTO_SENSITIVE_PREFIX("instance.crypto.opts.sensitive.", null,
PropertyType.PREFIX,
- "Sensitive properties related to on-disk file encryption."),
- @Experimental
- INSTANCE_CRYPTO_SERVICE("instance.crypto.service",
- "org.apache.accumulo.core.spi.crypto.NoCryptoService",
PropertyType.CLASSNAME,
- "The class which executes on-disk file encryption. The default does
nothing. To enable "
- + "encryption, replace this classname with an implementation of the"
- + "org.apache.accumulo.core.spi.crypto.CryptoService interface."),
-
Review comment:
I did at first but it was easier for me to implement the division of
table and WAL initially with them split up. I had problems at first since it
was ambiguous in the Accumulo code what the `CryptoService` was doing. The
tablet server for example initialized one at startup that could be used for
either. I had separate interfaces as well but this led to a lot of duplicate
code. Now that I split up the encrypt and decrypt across our mess of internal
file builders, it may be easier to go back and combine them into a central
service.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
