milleruntime commented on a change in pull request #1968:
URL: https://github.com/apache/accumulo/pull/1968#discussion_r597861015
##########
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##########
@@ -166,21 +166,6 @@
PropertyType.STRING,
"One-line configuration property controlling the network locations "
+ "(hostnames) that are allowed to impersonate other users"),
- // Crypto-related properties
- @Experimental
- INSTANCE_CRYPTO_PREFIX("instance.crypto.opts.", null, PropertyType.PREFIX,
- "Properties related to on-disk file encryption."),
- @Experimental
- @Sensitive
- INSTANCE_CRYPTO_SENSITIVE_PREFIX("instance.crypto.opts.sensitive.", null,
PropertyType.PREFIX,
- "Sensitive properties related to on-disk file encryption."),
- @Experimental
- INSTANCE_CRYPTO_SERVICE("instance.crypto.service",
- "org.apache.accumulo.core.spi.crypto.NoCryptoService",
PropertyType.CLASSNAME,
- "The class which executes on-disk file encryption. The default does
nothing. To enable "
- + "encryption, replace this classname with an implementation of the"
- + "org.apache.accumulo.core.spi.crypto.CryptoService interface."),
-
Review comment:
One issue I had was trying to specify an inner class in the
configuration. I am not sure why but this Java notation didn't seem to work:
`org.apache.accumulo.core.spi.crypto.CryptoService$AESGCMCryptoModule`
Any ideas if this can work with our classloading and/or configuration?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
