ctubbsii commented on pull request #1968: URL: https://github.com/apache/accumulo/pull/1968#issuecomment-810456687
> Although I don't understand how the ClassLoader code works with in regards to Table context, I think I see what you are getting at. I am not sure how to implement it though so I will probably step away from this for a bit. I don't think this pertains to ClassLoader code. I meant "context" in the generic sense of "surrounding environmental state for the action", not the per-table contexts for class loading. For these purposes, "context" would be something like: Type of crypter being requested (encrypter or decrypter), map of general crypto opts from system config AND one of: * WAL file name, map of any WAL-specific crypto opts from system config * Table name, RFile name, tablet?, map of table crypto opts from table-specific config > > > Accumulo passes the context to the singleton crypto service > > I thought we were trying to get away from static singleton classes? The impl that I was going for was object creation based on configuration. Not a static singleton. Just a singleton dangling off of ServerContext for the lifetime of the service. (We have this already today: `serverContext.getCryptoService()`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
