milleruntime commented on pull request #1968: URL: https://github.com/apache/accumulo/pull/1968#issuecomment-810582527
Another issue I ran into was how to get information down into BCFile. There is limited information for reading/writing once you get way down into the weeds: https://github.com/apache/accumulo/blob/0781550076f04d12716650fd64881d8b9d041afa/core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/BCFile.java#L317-L331 In this PR, I created the Encrypter or List<Decrypters> based on the configuration and passed that down into BCFile. If we want to create the environment object (`encryptionContext` or `decryptionContext` in your example) down in the belly of BCFile what do we pass to it? The safest way seems to pass `AccumuloConfiguration` down but I want to avoid having to refactor all of our internal file utilities every time we want to add something to the environment object. I guess we could pass down the environment object itself (`encryptionContext` or `decryptionContext`) creating it at the higher levels. But we would still need to create the CryptoService so we can call `cryptoService.getDecrypter(decryptionContext)` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
