ivakegg commented on a change in pull request #2006:
URL: https://github.com/apache/accumulo/pull/2006#discussion_r610796771
##########
File path:
server/base/src/main/java/org/apache/accumulo/server/master/balancer/HostRegexTableLoadBalancer.java
##########
@@ -220,7 +220,7 @@ protected String getPoolNameForTable(String tableName) {
* @param conf
* server configuration
*/
- protected void parseConfiguration(ServerConfiguration conf) {
Review comment:
> If I'm understanding these changes correctly, it seems the method
naming/refactoring isn't the important bit. Was that done for testing purposes
or some other reason?
>
> The most minimal versions of these changes seem to be to simply add two
additional `parseConfiguration` calls to the `getAssignments` and `balance`
methods. Can we go with the more minimal change without the method renaming/new
method?
The reason for the separate methods is because the Observer interface is
only for changes to the table configuration and hence updating system
properties from those listener methods is not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
