ctubbsii commented on a change in pull request #2006:
URL: https://github.com/apache/accumulo/pull/2006#discussion_r610819566
##########
File path:
server/base/src/main/java/org/apache/accumulo/server/master/balancer/HostRegexTableLoadBalancer.java
##########
@@ -220,7 +220,7 @@ protected String getPoolNameForTable(String tableName) {
* @param conf
* server configuration
*/
- protected void parseConfiguration(ServerConfiguration conf) {
Review comment:
Should we even bother with the observer rebuild, though, if we're
calling `parseSystemConfiguration` every time we balance, which calls
`parseTableConfiguration` every time? The point of the observer was to avoid
reparsing the config unless there was a change. Now, the config is reparsed
every time, no matter what, *plus* when the config changes.
Also, note that the observer interface stuff changed in the main branch.
And, I believe it may have changed in a way that would work for detecting
changes to the system config as well, but I'd have to check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
