Manno15 commented on a change in pull request #2084:
URL: https://github.com/apache/accumulo/pull/2084#discussion_r632529021
##########
File path:
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/MinorCompactor.java
##########
@@ -131,12 +134,21 @@ public CompactionStats call() {
reportedProblem = true;
} catch (RuntimeException | NoClassDefFoundError e) {
// if this is coming from a user iterator, it is possible that the
user could change the
- // iterator config and that the
- // minor compaction would succeed
+ // iterator config and that the minor compaction would succeed
+ // If the minor compaction stalls for too long during recovery, it
can interfere with
+ // other tables loading
+ // Throw exception if this happens so assignments can be rescheduled.
+ if (retryCounter >= 4 &&
mincReason.equals(MinorCompactionReason.RECOVERY)) {
+ log.warn("Minc is stuck for too long during recovery, throwing
error for reschedule.");
Review comment:
It does seem that the warn/error messaging in `AssignmentHandler` and
`MinorCompationTask` does include the key extent in the logging. I can still
include it in this log message to help track it. I do worry about log overload
throughout the whole process of rescheduling but I am not sure if that is an
actual issue or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
