dlmarion commented on pull request #2096:
URL: https://github.com/apache/accumulo/pull/2096#issuecomment-843220807


   @ctubbsii wrote:
   > it seems that the way the external compactions are exposed through to the 
user in the compaction configuration is through the specially named 
externalQueue
   
   The DefaultCompactionPlanner javadoc is out of date, it's doesn't describe 
`externalQueue`. Looking at `DefaultCompactionPlanner.ExecutorConfig` and 
`DefaultCompactionPlanner.init()` it seems it would be trivial to change the 
configuration so that it was more explicit. We could add a `type` field, for 
example:
   
   ```
   [
    {
      "name": "small",
      "type": "internal",
      "maxSize": "16M",
      "numThreads": 4
    },
    {
      "name": "large",
      "type": "external",
      "queue": "LargeQ"
    }
   ]
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to