keith-turner commented on a change in pull request #2096:
URL: https://github.com/apache/accumulo/pull/2096#discussion_r634730815



##########
File path: 
server/compaction-coordinator/src/main/java/org/apache/accumulo/coordinator/CompactionCoordinator.java
##########
@@ -313,6 +291,61 @@ public void run() {
     LOG.info("Shutting down");
   }
 
+  private void updateSummaries() {
+    ExecutorService executor =
+        ThreadPools.createFixedThreadPool(10, "Compaction Summary Gatherer", 
false);

Review comment:
       I Was thinking of % up to some max (was thinking a max of 10)... and 
then just decided on the max... that should get through even a large number of 
tsevers in short order, except when there are a good bit of unresponsive 
tservers... was also wondering if it should be configurable, but was thinking 
10 should be good and we can make it configurable if ever needed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to