Manno15 commented on pull request #2096: URL: https://github.com/apache/accumulo/pull/2096#issuecomment-844945493
> @Manno15 I think I may have fixed the issue you were seeing in 3095d3d, if line 1055 was the !closed check. That was an incorrect sanity check, looking at how the close() method works, closed could be true there and that would be ok. Yeah, that is the line I saw for 1055. I was running the latest commit on this branch at that time. > @Manno15 the feedback on logging was great. I made some quick changes with the following goals. Great, I like the logging changes you made. I will test them out today. > @Manno15 re the consistency of those fields, that data was coming from a thrift class and GSON generator json, so not sure they could reliably be ordered consistently. Ah, that makes sense. It's not a huge deal, just something I noticed while reading through it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
