milleruntime commented on a change in pull request #2096:
URL: https://github.com/apache/accumulo/pull/2096#discussion_r636076932
##########
File path:
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactableImpl.java
##########
@@ -277,6 +378,130 @@ private void checkIfUserCompactionCanceled() {
}
}
+ private void initializeSelection(
+ Map<ExternalCompactionId,ExternalCompactionMetadata> extCompactions,
Tablet tablet,
+ Map<ExternalCompactionId,String> externalCompactionsToRemove) {
+ CompactionKind extKind = null;
+ boolean unexpectedExternal = false;
+ Set<StoredTabletFile> tmpSelectedFiles = null;
+ Boolean selAll = null;
+ Long cid = null;
+ Boolean propDel = null;
+ int count = 0;
+
+ ArrayList<String> reasons = new ArrayList<>();
+
+ for (Entry<ExternalCompactionId,ExternalCompactionMetadata> entry :
extCompactions.entrySet()) {
Review comment:
A unit test would be even better! I could give that task a try, if you
want some help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
