DomGarguilo commented on a change in pull request #2118:
URL: https://github.com/apache/accumulo/pull/2118#discussion_r640800351
##########
File path:
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/tableImport/PopulateMetadataTable.java
##########
@@ -91,15 +91,11 @@ static void readMappingFile(VolumeManager fs,
ImportedTableInfo tableInfo, Strin
Path path = new Path(tableInfo.exportFile);
- BatchWriter mbw = null;
- ZipInputStream zis = null;
-
- try {
- VolumeManager fs = manager.getVolumeManager();
-
- mbw = manager.getContext().createBatchWriter(MetadataTable.NAME, new
BatchWriterConfig());
-
- zis = new ZipInputStream(fs.open(path));
+ try (
+ BatchWriter mbw =
+ manager.getContext().createBatchWriter(MetadataTable.NAME, new
BatchWriterConfig());
+ VolumeManager fs = manager.getVolumeManager();
Review comment:
[Recent discussion in another
ticket](https://github.com/apache/accumulo/pull/2117#discussion_r639859548)
makes me think this probably should be moved outside of the try-with-resources
block so it is not closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
