DomGarguilo commented on a change in pull request #2118:
URL: https://github.com/apache/accumulo/pull/2118#discussion_r640873796
##########
File path:
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/tableImport/PopulateMetadataTable.java
##########
@@ -91,15 +91,11 @@ static void readMappingFile(VolumeManager fs,
ImportedTableInfo tableInfo, Strin
Path path = new Path(tableInfo.exportFile);
- BatchWriter mbw = null;
- ZipInputStream zis = null;
-
- try {
- VolumeManager fs = manager.getVolumeManager();
-
- mbw = manager.getContext().createBatchWriter(MetadataTable.NAME, new
BatchWriterConfig());
-
- zis = new ZipInputStream(fs.open(path));
+ try (
+ BatchWriter mbw =
+ manager.getContext().createBatchWriter(MetadataTable.NAME, new
BatchWriterConfig());
+ VolumeManager fs = manager.getVolumeManager();
Review comment:
Im looking into it now. In this case it looks like it gets the
VolumeManager from Manager which is probably needed elsewhere. Also,
VolumeManager.close() has a comment saying:
> close the underlying FileSystems
Which leads me to believe it will close more than intended.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
