milleruntime commented on a change in pull request #2122:
URL: https://github.com/apache/accumulo/pull/2122#discussion_r644202126
##########
File path:
core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperations.java
##########
@@ -202,11 +202,32 @@ void removeProperty(String namespace, String property)
* if the user does not have permission
* @throws NamespaceNotFoundException
* if the specified namespace doesn't exist
- * @since 1.6.0
+ * @deprecated since 2.1.0; use {@link #getPropertiesMap(String)} instead.
*/
+ @Deprecated(since = "2.1.0")
Review comment:
Since there are two use cases for each type, it might be better to have
both methods. Also, the method that returns the iterable is used quite a lot
across the Accumulo code (a quick search showed me 51 places). I guess today I
am back to not deprecating the method. If the implementation uses the same
underlying method and without something better (like a new type that supports
`isSet()`) it doesn't seem necessary to deprecate. Sorry, API design is
difficult!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
