ctubbsii commented on a change in pull request #2122:
URL: https://github.com/apache/accumulo/pull/2122#discussion_r644986541



##########
File path: 
core/src/main/java/org/apache/accumulo/core/client/admin/NamespaceOperations.java
##########
@@ -202,11 +202,32 @@ void removeProperty(String namespace, String property)
    *           if the user does not have permission
    * @throws NamespaceNotFoundException
    *           if the specified namespace doesn't exist
-   * @since 1.6.0
+   * @deprecated since 2.1.0; use {@link #getPropertiesMap(String)} instead.
    */
+  @Deprecated(since = "2.1.0")

Review comment:
       I'm still in favor of deprecating. Some of the objections so far have 
been against removing, not against deprecating. The bar for deprecating should 
be much lower. I think API bloat is a harm that should be considered, and I 
think the SemVer process mitigates against the concerns over the worst effects 
of disruption. I would like to clean up API bloat over time, to streamline and 
simplify our API for ease of use in future, as well as accommodate existing 
users. I think the deprecation process with SemVer helps balance those 
competing goals, and think that some of the objections would have our API bloat 
over time. But, I think API evolution should also include the loss of vestigial 
APIs.
   
   However, as it stands, I'm outvoted here. So, unless others agree with me, 
that we should slowly phase out the old vestigial API, using deprecation as a 
start, we should keep both and not deprecate at this time.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to