keith-turner commented on a change in pull request #2152:
URL: https://github.com/apache/accumulo/pull/2152#discussion_r648457449
##########
File path:
core/src/main/java/org/apache/accumulo/core/metadata/schema/TabletMetadata.java
##########
@@ -429,6 +434,27 @@ private void setLocationOnce(String val, String qual,
LocationType lt) {
location = new Location(val, qual, lt);
}
+ static Iterable<TabletMetadata> convert(BatchScanner input,
EnumSet<ColumnType> fetchedColumns,
+ boolean buildKeyValueMap) {
+
+ IteratorSetting iterSetting = new IteratorSetting(100,
WholeRowIterator.class);
+ input.addScanIterator(iterSetting);
Review comment:
> It seems like a bad idea to put these inside this method, as they
mutate BatchScanner, which could be re-used by the caller.
Yeah that was awful. I was following the pattern of another existing
method, that had the same bad pattern. I inlined both methods in 887a91b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
