ctubbsii commented on a change in pull request #2169:
URL: https://github.com/apache/accumulo/pull/2169#discussion_r655652046
##########
File path:
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/delete/DeleteTable.java
##########
@@ -41,6 +42,19 @@ public DeleteTable(NamespaceId namespaceId, TableId tableId)
{
@Override
public long isReady(long tid, Manager env) throws Exception {
+
+ // Before attempting to delete the table, cancel any running user
+ // compactions.
+ if (Utils.reserveNamespace(env, namespaceId, tid, false, true,
TableOperation.COMPACT_CANCEL)
+ + Utils.reserveTable(env, tableId, tid, false, true,
TableOperation.COMPACT_CANCEL) == 0) {
+ try {
+ CancelCompactions.mutateZooKeeper(tid, tableId, env);
+ } finally {
+ Utils.unreserveTable(env, tableId, tid, false);
+ Utils.unreserveNamespace(env, namespaceId, tid, false);
+ }
+ }
+
return Utils.reserveNamespace(env, namespaceId, tid, false, false,
TableOperation.DELETE)
+ Utils.reserveTable(env, tableId, tid, true, true,
TableOperation.DELETE);
Review comment:
Not related to your changes, but is it weird that reserveNamespace is
okay with the namespace not existing (mustExist flag is false), but
reserveTable requires the table to exist (mustExist flag is true)? How can the
table exist without its namespace? And, would we want to try to delete a table
that's in a non-existent namespace?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
