keith-turner commented on a change in pull request #2175:
URL: https://github.com/apache/accumulo/pull/2175#discussion_r657251774
##########
File path:
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/delete/DeleteTable.java
##########
@@ -43,8 +43,13 @@ public DeleteTable(NamespaceId namespaceId, TableId tableId)
{
@Override
public long isReady(long tid, Manager env) throws Exception {
- // Before attempting to delete the table, cancel any running user
- // compactions.
+ // If we have the table write lock, then it's possible that we have
+ // already canceled the compactions and we can skip to deleting the tables.
+ if (Utils.hasNamespaceReadLock(env, namespaceId, tid)
+ && Utils.hasTableWriteLock(env, tableId, tid)) {
+ return 0;
+ }
+ // Cancel any running user compactions before deleting table
if (Utils.reserveNamespace(env, namespaceId, tid, false, true,
TableOperation.COMPACT_CANCEL)
Review comment:
@ctubbsii I think you were proposing the following? I put some
comments about what I was uncertain about. If those uncertainties were
resolved, I think it would be ok to have one repo prior to delete. I suspect
isReady() is called again, in that situation but I Am not certain.
```java
class PredeleteTable extends ManagerRepo {
public long isReady(long tid, Manager env) {
// attempt to get read lock to for cancel compactoin
return Utils.reserveNamespace(env, namespaceId, tid, false, true,
TableOperation.COMPACT_CANCEL) +
Utils.reserveTable(env, tableId, tid, false, true,
TableOperation.COMPACT_CANCEL);
}
public Repo<Manager> call(long tid, Manager env) {
CancelCompactions.mutateZooKeeper(tid, tableId, env);
Utils.unreserveTable(env, tableId, tid, false);
// if the manager dies here, will it call isReady() again later
before this method and if so, is that ok? If isReady were not called again,
could run CancelCompactions.mutateZooKeeper w/o holding lock
Utils.unreserveNamespace(env, namespaceId, tid, false);
// if the manager dies here, will it call isReady() again later
before this method and if so, is that ok? If isReady were not called again,
could run CancelCompactions.mutateZooKeeper w/o holding lock
return DeleteTable(...); // call the existing first fate op
}
@Override
public void undo(long tid, Manager env) {
Utils.unreserveTable(env, tableId, tid, false);
Utils.unreserveNamespace(env, namespaceId, tid, false);
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
