keith-turner commented on a change in pull request #2175:
URL: https://github.com/apache/accumulo/pull/2175#discussion_r657381019
##########
File path:
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/delete/DeleteTable.java
##########
@@ -43,8 +43,13 @@ public DeleteTable(NamespaceId namespaceId, TableId tableId)
{
@Override
public long isReady(long tid, Manager env) throws Exception {
- // Before attempting to delete the table, cancel any running user
- // compactions.
+ // If we have the table write lock, then it's possible that we have
+ // already canceled the compactions and we can skip to deleting the tables.
+ if (Utils.hasNamespaceReadLock(env, namespaceId, tid)
+ && Utils.hasTableWriteLock(env, tableId, tid)) {
+ return 0;
+ }
+ // Cancel any running user compactions before deleting table
if (Utils.reserveNamespace(env, namespaceId, tid, false, true,
TableOperation.COMPACT_CANCEL)
Review comment:
> So, I think 1-pre-step solution is fine (and preferred, because it's
simpler).
yeah w/ your analysis that seems good.
> so the implementation needed to cancel compactions for DeleteTable can
just set the compaction ID to a fixed maximum value, rather than even bother
checking what the current value is and mutating it.
That sounds good, just need to ensure that overflow does not happen if some
other code does try to increment it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
