milleruntime commented on pull request #2241: URL: https://github.com/apache/accumulo/pull/2241#issuecomment-904705067
> Would it be better if it was something more like srvContext ? It looks like we have other contexts (ClientContext, ClassLoaderContext) as well as M/R contexts. It may be that ServerContext and ClientContext are not used together - but with using 'context' anyone should not assume that all instances of context are server contexts. > > 'context' does read better, but wondering if there are benefits to being more specific to add clarity or if it just makes it harder to read for something that is already obvious. The other context objects are only used in specific classes. I went with the name that was most popular but I am not opposed to the more specific name `serverContext`. It would just require more changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
