milleruntime commented on pull request #2241: URL: https://github.com/apache/accumulo/pull/2241#issuecomment-904732539
Just comparing what is already in the code... To change the name to `serverContext` would require changing 147 files vs `context` in this PR only changes 23. The name `context` is used in MR classes for `JobContext`, for a private Context object in ContextManager, both of which are deprecated. But it is used for ClientContext in about 100 files and for a String type in `ContextClassLoaderFactory`, which is new. The way that the String type is used in `ContextClassLoaderFactory`, makes me think that it is the only object that should use the `context` variable name. As opposed to everywhere else we have specific types of context objects that we can be more specific (ClientContext, ServerContext, JobContext, etc). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
