DomGarguilo commented on a change in pull request #2235:
URL: https://github.com/apache/accumulo/pull/2235#discussion_r701172032
##########
File path:
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactableImpl.java
##########
@@ -1388,11 +1388,12 @@ public synchronized void close() {
closed = true;
- // wait while internal jobs are running or external compactions are
committing, but do not
- // wait on external compactions that are running
+ // wait while internal jobs are running, external compactions are
committing or the status of
+ // chops is active, but do not wait on external compactions that are
running
while (runningJobs.stream()
.anyMatch(job -> !((CompactionExecutorIdImpl)
job.getExecutor()).isExternalId())
- || !externalCompactionsCommitting.isEmpty()) {
+ || !externalCompactionsCommitting.isEmpty()
+ || fileMgr.chopStatus != FileSelectionStatus.NOT_ACTIVE) {
Review comment:
> > For this PR could add the new state to the existing enum and I can
fix it up later.
>
> Okay I'll go ahead and do that here
@keith-turner, Actually do you think that the new state should just be added
with the changes that will use it instead of adding it here before it is used
anywhere? It seems like this PR could just be closed if there are plans to
account for this later on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
