DomGarguilo commented on a change in pull request #2235:
URL: https://github.com/apache/accumulo/pull/2235#discussion_r717011448
##########
File path:
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CompactableImpl.java
##########
@@ -1388,11 +1388,12 @@ public synchronized void close() {
closed = true;
- // wait while internal jobs are running or external compactions are
committing, but do not
- // wait on external compactions that are running
+ // wait while internal jobs are running, external compactions are
committing or the status of
+ // chops is active, but do not wait on external compactions that are
running
while (runningJobs.stream()
.anyMatch(job -> !((CompactionExecutorIdImpl)
job.getExecutor()).isExternalId())
- || !externalCompactionsCommitting.isEmpty()) {
+ || !externalCompactionsCommitting.isEmpty()
+ || fileMgr.chopStatus != FileSelectionStatus.NOT_ACTIVE) {
Review comment:
I wasn't too sure how to best test to see if these changes affect
existing code so I ended up running all the ITs on this branch. Everything
looks good (except a failing ConcurrentDeleteTableIT which is known flaky and
also fails on main so is probably unrelated. Might create a ticket for this.).
I think these changes are ready for review @keith-turner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
