harjitdotsingh commented on pull request #2255: URL: https://github.com/apache/accumulo/pull/2255#issuecomment-911890771
> Complex regular expressions are difficult to read and maintain. Please try to avoid long regular expressions. > > Also please include a test with these changes to verify it is working correctly. Are there any existing test for the ShellCommands ? I will see if I can simplify the RegularExpression. I don't want to add to many if and conditions to parse something, that's not a good practice in general. I actually tested the RE in a JavaPlayGround to make sure it was splitting the way we wanted. I used the expression test:\test:test1 it gave me two strings 1) test:\test and 2) test1. I hope that is what is expected. Its possible that we may have to remove the \ from the first string so that the string is passed with : instead of it being escaped. DownStream code may not be handling the escaped string well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
