harjitdotsingh commented on pull request #2255: URL: https://github.com/apache/accumulo/pull/2255#issuecomment-919423120
We can Add it to the description. I think make it mutually exclusive make it more easier and the code manageable . We will have to add checks now to both the places. I like the suggestion though On Tue, Sep 14, 2021 at 2:42 PM Jeffrey Manno ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In shell/src/main/java/org/apache/accumulo/shell/commands/ScanCommand.java > <https://github.com/apache/accumulo/pull/2255#discussion_r708536553>: > > > @@ -348,6 +387,9 @@ public Options getOptions() { > optEndRowExclusive.setArgName("end-exclusive"); > scanOptRow = new Option("r", "row", true, "row to scan"); > scanOptColumns = new Option("c", "columns", true, "comma-separated columns"); > > Could mention that -c is mutually exclusive here so users will avoid the > thrown error above. One idea I had is if both options are passed in, we > could just log a warning and then choose to ignore one of the arguments > (either -c or -cf/cq). Thoughts on that? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/accumulo/pull/2255#pullrequestreview-754302789>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAASJ7R7B7UNHEZYL5Y3IYTUB6JQTANCNFSM5DGYZX4A> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
