ctubbsii commented on a change in pull request #155:
URL: https://github.com/apache/accumulo-testing/pull/155#discussion_r712626873
##########
File path:
src/main/java/org/apache/accumulo/testing/performance/tests/ConditionalMutationsPT.java
##########
@@ -101,7 +101,7 @@ private static void runConditionalMutationsTest(Environment
env, String tableNam
}
reportBuilder.result("avgRate: 1-19",
- Double.parseDouble(new DecimalFormat("#0.00").format(rateSum / 20)),
+ Double.parseDouble(new DecimalFormat("#0.00").format(rateSum / 19)),
Review comment:
Warming up seems reasonable. I just don't know why we have 19 subsequent
runs. It might make sense to just round the number of runs off to 20, rather
than use 19 as a divisor, which is a little confusing. The warm-up run would
benefit from an inline comment like `// warm-up run`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
