ctubbsii commented on a change in pull request #155:
URL: https://github.com/apache/accumulo-testing/pull/155#discussion_r715007299
##########
File path:
src/main/java/org/apache/accumulo/testing/performance/tests/ConditionalMutationsPT.java
##########
@@ -93,34 +93,37 @@ private static void runConditionalMutationsTest(Environment
env, String tableNam
ConditionalWriter cw = env.getClient().createConditionalWriter(tableName,
new ConditionalWriterConfig());
+ // warm-up run
conditionalMutationsTime(cw, 0);
double rateSum = 0.0;
- for (long i = 1; i < 20; i++) {
+ for (long i = 1; i < 21; i++) {
rateSum += conditionalMutationsTime(cw, i);
}
- reportBuilder.result("avgRate: 1-19",
+ reportBuilder.result("avgRate: 1-20",
Double.parseDouble(new DecimalFormat("#0.00").format(rateSum / 20)),
- "ConditionalMutationsTest: average rate (conditions/sec) to run
sequence 1-19");
+ "ConditionalMutationsTest: average rate (conditions/sec) to run
sequence 1-20");
env.getClient().tableOperations().flush(tableName, null, null, true);
rateSum = 0.0;
- for (long i = 20; i < 40; i++) {
+ for (long i = 21; i < 41; i++) {
Review comment:
```suggestion
for (long i = 21; i <= 40; i++) {
```
##########
File path:
src/main/java/org/apache/accumulo/testing/performance/tests/ConditionalMutationsPT.java
##########
@@ -248,43 +256,46 @@ private static void
runRandomizeBatchScanAndWriteTest(Environment env, String ta
BatchWriter bw = env.getClient().createBatchWriter(tableName, new
BatchWriterConfig());
BatchScanner bs = env.getClient().createBatchScanner(tableName,
Authorizations.EMPTY, 1);
+ // warm-up run
randomizeBatchWriteAndScanTime(bw, bs, 0);
double rateSum = 0;
- for (long i = 1; i < 20; i++) {
+ for (long i = 1; i < 21; i++) {
Review comment:
```suggestion
for (long i = 1; i <= 20; i++) {
```
##########
File path:
src/main/java/org/apache/accumulo/testing/performance/tests/ConditionalMutationsPT.java
##########
@@ -248,43 +256,46 @@ private static void
runRandomizeBatchScanAndWriteTest(Environment env, String ta
BatchWriter bw = env.getClient().createBatchWriter(tableName, new
BatchWriterConfig());
BatchScanner bs = env.getClient().createBatchScanner(tableName,
Authorizations.EMPTY, 1);
+ // warm-up run
randomizeBatchWriteAndScanTime(bw, bs, 0);
double rateSum = 0;
- for (long i = 1; i < 20; i++) {
+ for (long i = 1; i < 21; i++) {
rateSum += randomizeBatchWriteAndScanTime(bw, bs, i);
}
- reportBuilder.result("avgRate: 1-19",
+ reportBuilder.result("avgRate: 1-20",
Double.parseDouble(new DecimalFormat("#0.00").format(rateSum / 20)),
- "RandomizeBatchScanAndWriteTest: average rate (conditions/sec) to
write and scan sequence 1-19");
+ "RandomizeBatchScanAndWriteTest: average rate (conditions/sec) to
write and scan sequence 1-20");
env.getClient().tableOperations().flush(tableName, null, null, true);
rateSum = 0;
- for (long i = 20; i < 40; i++) {
+ for (long i = 21; i < 41; i++) {
Review comment:
```suggestion
for (long i = 21; i <= 40; i++) {
```
##########
File path:
src/main/java/org/apache/accumulo/testing/performance/tests/ConditionalMutationsPT.java
##########
@@ -93,34 +93,37 @@ private static void runConditionalMutationsTest(Environment
env, String tableNam
ConditionalWriter cw = env.getClient().createConditionalWriter(tableName,
new ConditionalWriterConfig());
+ // warm-up run
conditionalMutationsTime(cw, 0);
double rateSum = 0.0;
- for (long i = 1; i < 20; i++) {
+ for (long i = 1; i < 21; i++) {
Review comment:
I think it might be intuitive if `<=` were used:
```suggestion
for (long i = 1; i <= 20; i++) {
```
##########
File path:
src/main/java/org/apache/accumulo/testing/performance/tests/ConditionalMutationsPT.java
##########
@@ -165,42 +169,45 @@ private static void
runRandomizeConditionalMutationsTest(Environment env, String
ConditionalWriter cw = env.getClient().createConditionalWriter(tableName,
new ConditionalWriterConfig());
+ // warm-up run
randomizeConditionalMutationsTime(cw, 0);
double rateSum = 0;
- for (long i = 1; i < 20; i++) {
+ for (long i = 1; i < 21; i++) {
Review comment:
```suggestion
for (long i = 1; i <= 20; i++) {
```
##########
File path:
src/main/java/org/apache/accumulo/testing/performance/tests/ConditionalMutationsPT.java
##########
@@ -165,42 +169,45 @@ private static void
runRandomizeConditionalMutationsTest(Environment env, String
ConditionalWriter cw = env.getClient().createConditionalWriter(tableName,
new ConditionalWriterConfig());
+ // warm-up run
randomizeConditionalMutationsTime(cw, 0);
double rateSum = 0;
- for (long i = 1; i < 20; i++) {
+ for (long i = 1; i < 21; i++) {
rateSum += randomizeConditionalMutationsTime(cw, i);
}
- reportBuilder.result("avgRate: 1-19",
+ reportBuilder.result("avgRate: 1-20",
Double.parseDouble(new DecimalFormat("#0.00").format(rateSum / 20)),
- "RandomizeConditionalMutationsTest: average rate (conditions/sec) to
run sequence 1-19");
+ "RandomizeConditionalMutationsTest: average rate (conditions/sec) to
run sequence 1-20");
env.getClient().tableOperations().flush(tableName, null, null, true);
rateSum = 0;
- for (long i = 20; i < 40; i++) {
+ for (long i = 21; i < 41; i++) {
Review comment:
```suggestion
for (long i = 21; i <= 40; i++) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
