mjwall commented on a change in pull request #2293:
URL: https://github.com/apache/accumulo/pull/2293#discussion_r719745683
##########
File path:
server/gc/src/main/java/org/apache/accumulo/gc/GarbageCollectionAlgorithm.java
##########
@@ -172,18 +173,22 @@ private void confirmDeletes(GarbageCollectionEnvironment
gce,
}
+ Set<String> tableIdsBefore = gce.getTableIDs();
+ Set<String> tableIdsSeen = new HashSet<>();
Iterator<Entry<Key,Value>> iter = gce.getReferenceIterator();
while (iter.hasNext()) {
Entry<Key,Value> entry = iter.next();
Key key = entry.getKey();
Text cft = key.getColumnFamily();
+ tableIdsSeen.add(new String(KeyExtent.tableOfMetadataRow(key.getRow())));
if (cft.equals(DataFileColumnFamily.NAME) ||
cft.equals(ScanFileColumnFamily.NAME)) {
String cq = key.getColumnQualifier().toString();
String reference = cq;
if (cq.startsWith("/")) {
String tableID = new
String(KeyExtent.tableOfMetadataRow(key.getRow()));
+ tableIdsSeen.add(tableID);
Review comment:
This is a good change, I'll implement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
