mjwall commented on pull request #2293: URL: https://github.com/apache/accumulo/pull/2293#issuecomment-931690766
> > I considered adding some functions to TestGCE but then pulled out the logic to one method. I was hoping it would be enough to just test that method with different scenarios. That way we can explicitly pass in the before, seen and after and assert based on that. Interested in your thoughts. > > Not sure. The GCE/GCA distinction was created so that GCA could be tested. My goal would be to to get the most coverage of the GCA code as possible, but not sure of the best way to do that. I do like how you broke that method out and I do think unit test directly for that method would be very nice. Could possible make the method static instead of protected to test it. The question is can we also get coverage of other code in GCA that interacts with that method. Ok, thanks. I'll start with unit tests of that method and see about more "integrationy" tests as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
