dlmarion commented on a change in pull request #2293:
URL: https://github.com/apache/accumulo/pull/2293#discussion_r720195759
##########
File path:
server/gc/src/main/java/org/apache/accumulo/gc/GarbageCollectionAlgorithm.java
##########
@@ -217,11 +222,30 @@ private void confirmDeletes(GarbageCollectionEnvironment
gce,
throw new RuntimeException(
"Scanner over metadata table returned unexpected column : " +
entry.getKey());
}
+ Set<String> tableIdsAfter = gce.getTableIDs();
+ ensureAllTablesChecked(tableIdsBefore, tableIdsSeen, tableIdsAfter);
confirmDeletesFromReplication(gce.getReplicationNeededIterator(),
candidateMap.entrySet().iterator());
}
+ @VisibleForTesting
+ protected void ensureAllTablesChecked(Set<String> tableIdsBefore,
Set<String> tableIdsSeen,
+ Set<String> tableIdsAfter) {
+
+ // if a table was added or deleted during this run, it is acceptable to not
+ // have seen those tables ids when scanning the metadata table. So get the
intersection
+ Set<String> tableIdsMustHaveSeen = new HashSet<>(tableIdsBefore);
+ tableIdsMustHaveSeen.retainAll(tableIdsAfter);
Review comment:
`retainAll` returns a boolean to signify that the collection changed.
You could add it to the if statement.
```suggestion
if (tableIdsMustHaveSeen.retainAll(tableIdsAfter) &&
tableIdsMustHaveSeen.isEmpty() && !tableIdsSeen.isEmpty()) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
