milleruntime commented on a change in pull request #2303:
URL: https://github.com/apache/accumulo/pull/2303#discussion_r724164002
##########
File path:
minicluster/src/main/java/org/apache/accumulo/miniclusterImpl/MiniAccumuloClusterImpl.java
##########
@@ -773,8 +773,9 @@ public int stopProcessWithTimeout(final Process proc, long
timeout, TimeUnit uni
public ManagerMonitorInfo getManagerMonitorInfo()
throws AccumuloException, AccumuloSecurityException {
ManagerClientService.Iface client = null;
+ AccumuloClient c =
Accumulo.newClient().from(getClientProperties()).build();
while (true) {
- try (AccumuloClient c =
Accumulo.newClient().from(getClientProperties()).build()) {
+ try {
Review comment:
I don't think that will work. The loop needs to be around the exceptions
so it can retry in the event of a connection issue.
##########
File path:
minicluster/src/main/java/org/apache/accumulo/miniclusterImpl/MiniAccumuloClusterImpl.java
##########
@@ -773,8 +773,9 @@ public int stopProcessWithTimeout(final Process proc, long
timeout, TimeUnit uni
public ManagerMonitorInfo getManagerMonitorInfo()
throws AccumuloException, AccumuloSecurityException {
ManagerClientService.Iface client = null;
+ AccumuloClient c =
Accumulo.newClient().from(getClientProperties()).build();
while (true) {
- try (AccumuloClient c =
Accumulo.newClient().from(getClientProperties()).build()) {
+ try {
Review comment:
This seems like one place the `RetryableThriftFunction` for external
compactions @dlmarion added would be useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
