keith-turner commented on a change in pull request #2303:
URL: https://github.com/apache/accumulo/pull/2303#discussion_r726603903
##########
File path:
core/src/main/java/org/apache/accumulo/core/clientImpl/ClientContext.java
##########
@@ -915,4 +919,12 @@ public void setProperty(ClientProperty property, Integer
value) {
setProperty(property, Integer.toString(value));
}
}
+
+ public synchronized ThriftTransportPool getTransportPool() {
+ if (thriftTransportPool == null) {
Review comment:
```suggestion
ensureOpen();
if (thriftTransportPool == null) {
```
##########
File path:
minicluster/src/main/java/org/apache/accumulo/miniclusterImpl/MiniAccumuloClusterImpl.java
##########
@@ -787,8 +788,9 @@ public ManagerMonitorInfo getManagerMonitorInfo()
throw new AccumuloException(exception);
} finally {
if (client != null) {
- ManagerClient.close(client);
+ ManagerClient.close(client, (ClientContext) c);
}
+ c.close();
Review comment:
Is this close inside the loop? If so, does another client need to be
opened for the next loop iteration? Or maybe have pattern like the following :
```java
try(AccumuloClient c =
Accumulo.newClient().from(getClientProperties()).build()){
while(true){
try {...} ...
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
