ctubbsii commented on a change in pull request #2321:
URL: https://github.com/apache/accumulo/pull/2321#discussion_r735851640
##########
File path:
server/base/src/main/java/org/apache/accumulo/server/rpc/HighlyAvailableServiceInvocationHandler.java
##########
@@ -49,8 +49,12 @@ public HighlyAvailableServiceInvocationHandler(I instance,
HighlyAvailableServic
public Object invoke(Object proxy, Method method, Object[] args) throws
Throwable {
// If the service is not active, throw an exception
if (!service.isActiveService()) {
- LOG.trace("Denying access to RPC service as this instance is not the
active instance.");
- throw new ThriftNotActiveServiceException();
+ if (!service.isUpgrading()) {
+ LOG.trace("Denying access to RPC service as this instance is not the
active instance.");
+ throw new ThriftNotActiveServiceException();
+ }
+ LOG.warn("Cannot access service while it is upgrading.");
+ return null;
Review comment:
This puts the warning about upgrading in the body of the if block where
it is *not* the active service. Isn't the main problem when it *is* the active
service?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
