Manno15 commented on a change in pull request #2321:
URL: https://github.com/apache/accumulo/pull/2321#discussion_r735855868
##########
File path:
server/base/src/main/java/org/apache/accumulo/server/rpc/HighlyAvailableServiceInvocationHandler.java
##########
@@ -49,8 +49,12 @@ public HighlyAvailableServiceInvocationHandler(I instance,
HighlyAvailableServic
public Object invoke(Object proxy, Method method, Object[] args) throws
Throwable {
// If the service is not active, throw an exception
if (!service.isActiveService()) {
- LOG.trace("Denying access to RPC service as this instance is not the
active instance.");
- throw new ThriftNotActiveServiceException();
+ if (!service.isUpgrading()) {
+ LOG.trace("Denying access to RPC service as this instance is not the
active instance.");
+ throw new ThriftNotActiveServiceException();
+ }
+ LOG.warn("Cannot access service while it is upgrading.");
+ return null;
Review comment:
The issue is when the Manager is not an active service (because it
hasn't completed initialization) because it is still in the process of
upgrading. Not due to an error of some kind. the isActiveService only checks
for a boolean inside manager that gets set to true when it is determined that
it has completed initialization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
